@rklaehn okay, so I've done all the errors...except GetError. I tried my best for the rest of the errors to maintain everything as closely as possible to the structure that already existed.

The typical conversion should go like something like this:

.map_err(|e| GetError::LocalFailure(e.into()))?

becomes:

.map_err(anyhow::Error) // because all the sources are `anyhow:Error` in the `GetError` enum
.context(LocalFailureSnafu)?

But in src/api/remote.rs, for example, we can't seem to get access to LocalFailureSnafu, no matter what pub visibility level I make the get::error module. I'm at a loss. There may be something obvious I'm missing but I can't figure it out.

Asking for help!

I think the visibility thing is just because the error module is not publicly exported. I just use the module as a way to structure the code, but then export just the error one level up.

I now have 2 branches where I got snafu everywhere, but I am not happy with any of them.

In this branch: https://github.com/n0-computer/blobs2/tree/snafu-errors I just make GetError a big list of things that can go wrong. But that was not what it was meant to be. A user now has to look into each of the cases and check each of the sub cases to see if e.g. the error is recoverable (Io) or indicates a hopeless node (NonCompliantNode). I guess I could make an enum ErrorCategory and have a fn where I do this for the users.

In this branch: https://github.com/n0-computer/blobs2/tree/snafu-errors-2nd-attempt I keep the structure as it is and make a XXXCases error enum that is the sum of all sub-cases for that particular case. It does the job, but I find it super verbose.

I think the second one is the better option: #2

@rklaehn I agree, #2 looks good

@rklaehn i'm in favor of closing this PR for #2